Skip to content

feat(command): add ACL commands, validate module categories exist #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 5, 2025
Merged

feat(command): add ACL commands, validate module categories exist #3262

merged 8 commits into from
Feb 5, 2025

Conversation

@ndyakov
Copy link
Member

@ndyakov ndyakov commented Feb 4, 2025 •
edited
Loading

  • Add ACL SETUSER and ACL DELUSER
  • Add ACL CAT (ACLCat and ACLCatWithArgs for ACL CAT [category])
  • Validate categories for modules exist in the output of cat for redis >=8
  • Validate different acl for both commands and categories work for modules

@ndyakov ndyakov force-pushed the ndyakov/acl-redis-8 branch from d5cea4e to c609df4 Compare February 4, 2025 14:11
@ndyakov ndyakov changed the title Ndyakov/acl redis 8 feat: add ACL commands, validate module categories exist Feb 4, 2025
@ndyakov ndyakov requested a review from vladvildanov February 4, 2025 18:32
@ndyakov ndyakov marked this pull request as ready for review February 4, 2025 18:35
@ndyakov ndyakov changed the title feat: add ACL commands, validate module categories exist feat(command): add ACL commands, validate module categories exist Feb 4, 2025
@ndyakov ndyakov requested a review from ofekshenawa February 5, 2025 08:04
ofekshenawa
ofekshenawa reviewed Feb 5, 2025
View reviewed changes
ofekshenawa
ofekshenawa reviewed Feb 5, 2025
View reviewed changes
ofekshenawa
ofekshenawa reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@ofekshenawa ofekshenawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small comment. Also, since you separated the ACL command tests, it might be best to move the remaining ACL command tests from commands_test to acl_commands_test for consistency

@ndyakov ndyakov force-pushed the ndyakov/acl-redis-8 branch from 451c64a to 555f384 Compare February 5, 2025 09:53
@ndyakov ndyakov merged commit 0b34b19 into master Feb 5, 2025
15 checks passed
@ndyakov ndyakov mentioned this pull request Feb 7, 2025
Draft
@ndyakov ndyakov deleted the ndyakov/acl-redis-8 branch February 7, 2025 09:29
ofekshenawa pushed a commit that referenced this pull request Aug 10, 2025
@ndyakov @ofekshenawa
feat(command): add ACL commands, validate module categories exist (#3262
d4ddfe9 
)

* add ACL{SetUser,DelUser,List} commands

* test presence of categories in acl cat

* code cleanup

* add basic acl tests

* add acl modules tests

* reset acl log before test

* refactor acl tests

* fix clientkillbyage test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ofekshenawa ofekshenawa ofekshenawa approved these changes

@vladvildanov vladvildanov Awaiting requested review from vladvildanov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndyakov @ofekshenawa